ask-password: prevent buffer overflow when reading from keyring
authorThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Mon, 13 May 2019 19:58:01 +0000 (16:58 -0300)
committerMichael Biebl <biebl@debian.org>
Thu, 29 Aug 2019 14:18:18 +0000 (15:18 +0100)
commit0a9dcc7f4d0f917ae568e3be11b985394d4abd80
treeb6139d8e61302bcda4e1e55cd4df9ed215d0a512
parent2a1814b5197441affc72b1a4b8ccfbe89e352814
ask-password: prevent buffer overflow when reading from keyring

When we read from keyring, a temporary buffer is allocated in order to
determine the size needed for the entire data. However, when zeroing that area,
we use the data size returned by the read instead of the lesser size allocate
for the buffer.

That will cause memory corruption that causes systemd-cryptsetup to crash
either when a single large password is used or when multiple passwords have
already been pushed to the keyring.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
(cherry picked from commit 59c55e73eaee345e1ee67c23eace8895ed499693)

Gbp-Pq: Name ask-password-prevent-buffer-overflow-when-reading-from-ke.patch
src/shared/ask-password-api.c